streamingest: flush first resolved event in stream ingestion #61301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit properly initializes the lastFlushTime to be far in the future so that we always flush on the first event. This change unflakes TestRandomClientGeneration. Release justification: fix test flake Release note: None
|
This change is |
|
Will rebase to unskip the test once #61292 is merged. |
|
Looking at this again, I think we actually properly handle the lastFlushTime being far in the past. I'm not sure how this seemed to deflake the test. Going to stress it more and come back with another approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit properly initializes the lastFlushTime to be far in the
future so that we always flush on the first event. This change unflakes
TestRandomClientGeneration.
Fixes ##61287.
Release justification: fix test flake
Release note: None