Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: quiet logging an error when context is canceled #57544

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

ajwerner
Copy link
Contributor

@ajwerner ajwerner commented Dec 4, 2020

This was showing up during shutdown. Presumably this indicates that we should
be waiting for these jobs to terminate and is a hint that there's a graceful
shutdown problem, however, we already know that we have these.

Release note: None

This was showing up during shutdown. Presumably this indicates that we should
be waiting for these jobs to terminate and is a hint that there's a graceful
shutdown problem, however, we already know that we have these.

Release note: None
@ajwerner ajwerner requested a review from thoszhang December 4, 2020 06:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner ajwerner changed the title ljobs: quiet logging an error when context is canceled jobs: quiet logging an error when context is canceled Dec 4, 2020
Copy link
Contributor

@thoszhang thoszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@ajwerner
Copy link
Contributor Author

ajwerner commented Dec 4, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 4, 2020

Build succeeded:

@craig craig bot merged commit 826ab33 into cockroachdb:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants