sql: remove testing.vectorize.batch_size setting #57401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Before merging this, we need to fix the metamorphic nightly build. @jordanlewis do you know whether there is much left to do there? |
yuzefovich
force-pushed
the
batch-size
branch
2 times, most recently
from
f9bad59 to
3a17fbd
Compare
With the recent addition of the metamorphic build tag we no longer need to expose the `sql.testing.vectorize.batch_size` cluster setting in order to randomize `coldata.BatchSize()` for testing purposes, so this commit retires the setting. The only testing coverage we're losing is `tpchvec/smallbatchsize` test, but I don't think it ever found any issues, so it doesn't seem important to figure out how to use the metamorphic tag for it. Release note: None (removing non-public setting)
yuzefovich
force-pushed
the
batch-size
branch
from
3a17fbd to
6e6ec8e
Compare
|
I'll fix up all of the issues with metamorphic test in #57483. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent addition of the metamorphic build tag we no longer need
to expose the
sql.testing.vectorize.batch_sizecluster setting inorder to randomize
coldata.BatchSize()for testing purposes, so thiscommit retires the setting. The only testing coverage we're losing is
tpchvec/smallbatchsizetest, but I don't think it ever found anyissues, so it doesn't seem important to figure out how to use the
metamorphic tag for it.
Fixes: #51156.
Fixes: #57088.
Fixes: #57198.
Addresses: #55348.
Release note: None (removing non-public setting)