sql,clusterversion: remove VersionAuthLocalAndTrustRejectMethods #57156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
irfansharif
force-pushed
the
201125.del-VersionAuthLocalAndTrustRejectMethods
branch
from
b389fb2 to
0bf98a9
Compare
irfansharif
force-pushed
the
201125.del-VersionAuthLocalAndTrustRejectMethods
branch
from
0bf98a9 to
4bfaac0
Compare
tbg
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 13 of 13 files at r2, 5 of 5 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @knz)
irfansharif
force-pushed
the
201125.del-VersionAuthLocalAndTrustRejectMethods
branch
from
4bfaac0 to
51813a2
Compare
|
bors r+ |
This, and all surrounding migration code and tests, are now safe to remove. It mostly served as documentation, which we've moved to the field itself. Part of cockroachdb#47447. Fixes cockroachdb#56401. (While here, Let's also tell git that `versionkey_string.go` is a generated file.) Release note: None
irfansharif
force-pushed
the
201125.del-VersionAuthLocalAndTrustRejectMethods
branch
from
51813a2 to
86859a7
Compare
|
Canceled. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 27, 2020
57118: migration,server: plumb in initial version to the migration manager r=irfansharif a=irfansharif It'll let us return early, and makes the manager "more functional" in its behavior. We also promote the clusterversion type to a first-class citizen in the external facing API for pkg/migration. This package concerns itself with migrations between cluster versions and we should have our API reflect as much. The proto changes are safe, we haven't had a major release with the previous proto definitions. Release note: None 57155: clusterversion,*: remove VersionContainsEstimatesCounter r=irfansharif a=irfansharif This, and all surrounding migration code and tests, are now safe to remove. It mostly served as documentation, which we've moved to the field itself. Part of #47447. Fixes #56401. (While here, Let's also tell git that `versionkey_string.go` is a generated file.) Release note: None --- First commit is from #57154. 57156: sql,clusterversion: remove VersionAuthLocalAndTrustRejectMethods r=irfansharif a=irfansharif It's an old cluster version, introduced in the 19.2 release cycle. It's now safe to remove. Part of #47447. Fixes #56398. Release note: None --- See only last commit. First two are from #57154 and #57155 respectively. Co-authored-by: irfan sharif <[email protected]>
|
Build failed (retrying...): |
irfansharif
force-pushed
the
201125.del-VersionAuthLocalAndTrustRejectMethods
branch
from
86859a7 to
a357f4f
Compare
|
Canceled. |
|
bors r+ |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
It's an old cluster version, introduced in the 19.2 release cycle. It's now safe to remove. Part of cockroachdb#47447. Fixes cockroachdb#56398. Release note: None
irfansharif
force-pushed
the
201125.del-VersionAuthLocalAndTrustRejectMethods
branch
from
a357f4f to
ebf8c3e
Compare
|
bors r+ |
|
Build succeeded: |
irfansharif
deleted the
201125.del-VersionAuthLocalAndTrustRejectMethods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an old cluster version, introduced in the 19.2 release cycle. It's
now safe to remove. Part of #47447. Fixes #56398.
Release note: None
See only last commit. First two are from #57154 and #57155 respectively.