Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration,server: plumb in initial version to the migration manager #57118

Merged
merged 5 commits into from
Nov 28, 2020
Merged

migration,server: plumb in initial version to the migration manager #57118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d98aa66
clusterversion: document process for introducing cluster versions
irfansharif Nov 26, 2020
a506329
clusterversion: move version comments next to definition
irfansharif Nov 26, 2020
93812e9
migration,server: plumb in initial version to the migration manager
irfansharif Nov 25, 2020
e8c3b90
clusterversion: rename proto pkg name for cleaner import path
irfansharif Nov 25, 2020
3783e63
migration: promote clusterversion to first-class citizen...
irfansharif Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions pkg/clusterversion/cluster_version.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/clusterversion/cluster_version.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// licenses/APL.txt.

syntax = "proto3";
package cockroach.base;
package cockroach.clusterversion;
option go_package = "clusterversion";

import "roachpb/metadata.proto";
Expand Down
2 changes: 1 addition & 1 deletion pkg/clusterversion/clusterversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ type Handle interface {
//
// If this returns true then all nodes in the cluster will eventually see
// this version. However, this is not atomic because version gates (for a
// given version) are pushed through to each node in parallel. Because of
// given version) are pushed through to each node concurrently. Because of
// this, nodes should not be gating proper handling of remotely initiated
// requests that their binary knows how to handle on this state. The
// following example shows why this is important:
Expand Down
Loading