release-20.2: sql: normalize age and timestamptz intervals like postgres #56751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This reverts commit 88a5d94. Release note: None
Release note (sql change, bug fix): Previously, `timestamp/timestamptz -
timestamp/timestamptz` operators would normalize the interval into
months, days, H:M:S (in older versions, this may be just H:M:S).
This could result in an incorrect result:
```
> select '2020-01-01'::timestamptz - '2018-01-01';
?column?
-------------------
2 years 10 days
```
This has now been fixed such that it is only normalized into
days/H:M:S. This is now more postgres compatible.
Release note (sql change, bug fix): Previously, the `age` builtin would
incorrectly normalize months and days based on 30 days a month (in older
versions this may be just H:M:S).
This can give an incorrect result, e.g.
```
> select age('2020-01-01'::timestamptz, '2018-01-01');
?column?
-------------------
2 years 10 days
```
This is not the most accurate it could be as `age` can use the given
timestamptz arguments to be more accurate.
This is now more postgres compatible.
otan
force-pushed
the
backport20.2-56667
branch
from
7916a36 to
d2c0836
Compare
solongordon
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #56667.
/cc @cockroachdb/release
sql: normalize age and timestamptz intervals like postgres
Release note (sql change, bug fix): Previously,
timestamp/timestamptz - timestamp/timestamptzoperators would normalize the interval intomonths, days, H:M:S (in older versions, this may be just H:M:S).
This could result in an incorrect result:
This has now been fixed such that it is only normalized into
days/H:M:S. This is now more postgres compatible.
Release note (sql change, bug fix): Previously, the
agebuiltin wouldincorrectly normalize months and days based on 30 days a month (in older
versions this may be just H:M:S).
This can give an incorrect result, e.g.
This is not the most accurate it could be as
agecan use the giventimestamptz arguments to be more accurate.
This is now more postgres compatible.
Revert "sql: age returns normalized intervals"
This reverts commit 88a5d94.
Release note: None