importccl: always ignore PGDUMP statements in ignorelist #56324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would only ignore statements that were in our ignorelist if we could not parse them. However, as we add the ability to parse new statements, that does not mean that IMPORT supports them just yet. Release note: None
|
This change is |
|
I'm curious what other's thoughts are here and that if IMPORT should start supporting these expressions as soon as we start being able to parse them? I could see an argument either way on that. |
dt
approved these changes
Nov 10, 2020
|
TFTR |
|
Build succeeded: |
This was referenced Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would only ignore statements that were in our ignorelist
if we could not parse them. However, as we add the ability to parse new
statements, that does not mean that IMPORT supports them just yet.
Fixes #53958.
Release note: None