Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partialidx: add benchmarks for two-variable comparisons #56095

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

mgartner
Copy link
Collaborator

Two-variable comparison implication performs similarly to other types of
implications.

BenchmarkImplicator/single-exact-match-16                         76.5 ns/op
BenchmarkImplicator/single-inexact-match-16                      342 ns/op
BenchmarkImplicator/range-inexact-match-16                       782 ns/op
BenchmarkImplicator/two-var-comparison-16                        302 ns/op
BenchmarkImplicator/single-exact-match-extra-filters-16          310 ns/op
BenchmarkImplicator/single-inexact-match-extra-filters-16        609 ns/op
BenchmarkImplicator/multi-column-and-exact-match-16               82.4 ns/op
BenchmarkImplicator/multi-column-and-inexact-match-16            722 ns/op
BenchmarkImplicator/multi-column-and-two-var-comparisons-16      611 ns/op
BenchmarkImplicator/multi-column-or-exact-match-16                76.1 ns/op
BenchmarkImplicator/multi-column-or-exact-match-reverse-16       595 ns/op
BenchmarkImplicator/multi-column-or-inexact-match-16            1081 ns/op
BenchmarkImplicator/in-implies-or-16                             976 ns/op
BenchmarkImplicator/and-filters-do-not-imply-pred-16            3710 ns/op
BenchmarkImplicator/or-filters-do-not-imply-pred-16              917 ns/op
BenchmarkImplicator/many-columns-exact-match10-16                296 ns/op
BenchmarkImplicator/many-columns-inexact-match10-16             6853 ns/op
BenchmarkImplicator/many-columns-exact-match100-16             19817 ns/op
BenchmarkImplicator/many-columns-inexact-match100-16          447894 ns/op

Release note: None

Two-variable comparison implication performs similarly to other types of
implications.

    BenchmarkImplicator/single-exact-match-16                         76.5 ns/op
    BenchmarkImplicator/single-inexact-match-16                      342 ns/op
    BenchmarkImplicator/range-inexact-match-16                       782 ns/op
    BenchmarkImplicator/two-var-comparison-16                        302 ns/op
    BenchmarkImplicator/single-exact-match-extra-filters-16          310 ns/op
    BenchmarkImplicator/single-inexact-match-extra-filters-16        609 ns/op
    BenchmarkImplicator/multi-column-and-exact-match-16               82.4 ns/op
    BenchmarkImplicator/multi-column-and-inexact-match-16            722 ns/op
    BenchmarkImplicator/multi-column-and-two-var-comparisons-16      611 ns/op
    BenchmarkImplicator/multi-column-or-exact-match-16                76.1 ns/op
    BenchmarkImplicator/multi-column-or-exact-match-reverse-16       595 ns/op
    BenchmarkImplicator/multi-column-or-inexact-match-16            1081 ns/op
    BenchmarkImplicator/in-implies-or-16                             976 ns/op
    BenchmarkImplicator/and-filters-do-not-imply-pred-16            3710 ns/op
    BenchmarkImplicator/or-filters-do-not-imply-pred-16              917 ns/op
    BenchmarkImplicator/many-columns-exact-match10-16                296 ns/op
    BenchmarkImplicator/many-columns-inexact-match10-16             6853 ns/op
    BenchmarkImplicator/many-columns-exact-match100-16             19817 ns/op
    BenchmarkImplicator/many-columns-inexact-match100-16          447894 ns/op

Release note: None
@mgartner mgartner requested a review from RaduBerinde October 28, 2020 19:00
@mgartner mgartner requested a review from a team as a code owner October 28, 2020 19:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner
Copy link
Collaborator Author

Found this old branch I had forgotten to make a PR for.

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)

@mgartner
Copy link
Collaborator Author

bors r=RaduBerinde

@craig
Copy link
Contributor

craig bot commented Oct 28, 2020

Build succeeded:

@craig craig bot merged commit 67dab4c into cockroachdb:master Oct 28, 2020
@mgartner mgartner deleted the bench-two-var-implication branch October 28, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants