storage: Bring back MaxSyncDuration env var, fix disk-stalled roachtest #56064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @itsbilal, @jbowens, and @petermattis)
pkg/cmd/roachtest/disk_stall.go, line 100 at r1 (raw file):
dur := 10 * time.Minute if !affectsDataDir && !affectsLogDir { dur = 65 * time.Second
Did this duration need to change?
The disk-stalled roachtest relies on the ability to control disk stall detection / fatal intervals, as charybdefs only injects 50ms of delay per syscall. This change adds an env variable, similar to the one removed in cockroachdb#55186 to set max sync duration, except now it governs the default of the cluster setting. The roachtest now modifies that env variable to let disk stall detection trip on short syscall delays. Fixes cockroachdb#54332. Release note: None.
itsbilal
force-pushed
the
fix-disk-stall-roachtest
branch
from
e656a64 to
79f1751
Compare
itsbilal
commented
Oct 28, 2020
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/cmd/roachtest/disk_stall.go, line 100 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
Did this duration need to change?
It doesn't. Reverted.
|
bors r+ |
|
Build succeeded: |
itsbilal
added a commit
to itsbilal/cockroach
that referenced
this pull request
Nov 2, 2020
The COCKROACH_ENGINE_MAX_SYNC_DEFAULT* env variables were overhauled after 20.2. The roachtest was updated in cockroachdb#56064 to use the new env vars that yield to cluster settings. However, that roachtest was also not updated to work correctly with <=20.2 cockroach that still looked for the older env vars, so this change makes that fix. Fixes cockroachdb#56174. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disk-stalled roachtest relies on the ability to control disk stall
detection / fatal intervals, as charybdefs only injects 50ms of
delay per syscall. This change adds an env variable, similar to the
one removed in #55186 to set max sync duration, except now it governs
the default of the cluster setting. The roachtest now modifies that
env variable to let disk stall detection trip on short syscall
delays.
Fixes #54332.
Release note: None.