Revert "tpcc: use multiple column families to avoid contention" #55983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b11918. Fixes cockroachdb#55954. Fixes cockroachdb#55953. Fixes cockroachdb#55952. Fixes cockroachdb#55951. Fixes cockroachdb#55949. In cockroachdb#30624, we split various column families up in the TPC-C workload. This had the unintended consequence of breaking CDC roachtests, because CDC does not support multiple column families per row: ``` CHANGEFEEDs are currently supported on tables with exactly 1 column family: warehouse has 2 ``` This PR reverts that commit. I intend to come back to this and introduce a `--families` flag to TPC-C (like we have to YCSB) that can be used to selectively toggle column families on or off. However, I'll do this after cockroachdb#51897 lands, because it's going to be more effort than it's worth to conditionally set this flag based on whether the version of workload used in the test supports it or not.
|
This change is |
aayushshah15
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @aayushshah15)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6b11918.
Fixes #55954.
Fixes #55953.
Fixes #55952.
Fixes #55951.
Fixes #55949.
In #30624, we split various column families up in the TPC-C workload. This
had the unintended consequence of breaking CDC roachtests, because CDC
does not support multiple column families per row:
This PR reverts that commit. I intend to come back to this and introduce
a
--familiesflag to TPC-C (like we have to YCSB) that can be used toselectively toggle column families on or off. However, I'll do this
after #51897 lands, because it's going to be more effort than it's worth
to conditionally set this flag based on whether the version of workload
used in the test supports it or not.