-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-20.2: cmd: wholesale replace roachprod, roachtest, workload from master #55899
release-20.2: cmd: wholesale replace roachprod, roachtest, workload from master #55899
Conversation
7ae2daf
to
2edfc5b
Compare
@@ -22,6 +22,7 @@ func registerInconsistency(r *testRegistry) { | |||
r.Add(testSpec{ | |||
Name: fmt.Sprintf("inconsistency"), | |||
Owner: OwnerKV, | |||
Skip: "Uses RocksDB put command; unskip when that's bypassed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO(adityamaru): Check if this has been unskipped since I picked the version of roachtest from master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, I am going to rely on engineers backporting all their changes since October 22nd themselves. I will ping storage since this caught my eye but I suspect there could be others.
@irfansharif I've not tagged the PRs corresponding to the changes to the roachtests in this branch since the diff is a lot smaller. If you think it'll help I'm happy to do it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I've not tagged the PRs corresponding to the changes to the roachtests in this branch since the diff is a lot smaller. If you think it'll help I'm happy to do it!
There was no need, I think I've seen most of the original PRs fly by. Thanks!
Release note: None
2edfc5b
to
ee74271
Compare
Going to merge this, I have changed the build configs for both AWS and GCE for release-20.1/20.2 to now build off the branch itself. I am going to trigger an AWS nightly CI run just to sanity check. |
Nice, thank you for doing this. This means that roachtest changes on master will now only affect the master branch as of now, right? |
Yep that's right. Sending out an announcement soon. |
Informs: #51897