tpcc: remove unused and unpartitionable stock_item_fk_idx #55638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @aayushshah15 and @dt)
This was discussed in cockroachdb#50911. We ended up not making the change because it didn't appear to improve performance. Given the fact that the index is only used in a single place and can easily be replaced by the primary key of the stock table, it doesn't seem possible that this would actually hurt performance. However, it does seem possible for the index to hurt performance in multi-region clusters, where the fk validation was not guaranteed to be local because it was not using the partitioned primary key of the stock table. This allows us to remove a scary comment around partitioning code, because the index was not partitionable by warehouse id.
nvanbenschoten
force-pushed
the
nvanbenschoten/removeStockFK
branch
from
94fc818 to
a0da596
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in #50911. We ended up not making the change because
it didn't appear to improve performance. Given the fact that the index
is only used in a single place and can easily be replaced by the primary
key of the stock table, it doesn't seem possible that this would
actually hurt performance. However, it does seem possible for the index
to hurt performance in multi-region clusters, where the fk validation
was not guaranteed to be local because it was not using the partitioned
primary key of the stock table.
This allows us to remove a scary comment around partitioning code,
because the index was not partitionable by warehouse id.