release-20.2: sql: anonymize schema names, owner names, and enum values #55508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema and owner names were improperly being represented by strings rather than `tree.Name`s in the AST. This meant they would not be properly anonymized in telemetry. Fixes cockroachdb#55385 Release note: None
ENUM values were improperly being represented as strings in the AST, which meant that they were not anonymized in telemetry. I created a new AST node type for them which respects anonymization. Fixes cockroachdb#55385 Release note: None
|
This change is |
thoszhang
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Reviewed 21 of 21 files at r1, 9 of 9 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @knz)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #55473.
/cc @cockroachdb/release
Schema and owner names were improperly being represented by strings
rather than
tree.Names in the AST. This meant they would not beproperly anonymized in telemetry.
ENUM values had the same problem, but we cannot use
tree.Nameinthis case because we need the values to be quoted. I created a custom AST
node for this case.
Fixes #55385
Release note: None