sql: ensure backfills use the same timestamp in their evalContext #54891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/fix-bug-in-schema-changer-with-restarts-and-checkpoints
branch
from
7792321 to
6d529cd
Compare
thoszhang
reviewed
Sep 29, 2020
There was a problem hiding this comment.
I'm fine with the first commit (in particular, with backporting it), but I'm not entirely sold on changing the backfill timestamp behavior for 20.2, since it is a flaw we've had for a while. I think we should at least think of that as a separate change and discuss it in a separate PR.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt)
|
@lucy-zhang the first commit is now #54900. When that merges I'll rebase here and we can discuss. |
This fixes a bug whereby column backfills which are restarted and rely on `now()` or functions like it actually return the same value throughout the backfill. Release note (bug fix): Fixed a bug in column additions which utilized time functions that could lead to multiple different values being used throughout a backfill if an internal restart occurred.
ajwerner
force-pushed
the
ajwerner/fix-bug-in-schema-changer-with-restarts-and-checkpoints
branch
from
6d529cd to
a5a8f02
Compare
ajwerner
changed the title
|
I'm fine with not backporting this. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug whereby column backfills which are restarted and rely on
now()or functions like it actually return the same value throughoutthe backfill.
Release note (bug fix): Fixed a bug in column additions which utilized time
functions that could lead to multiple different values being used throughout
a backfill if an internal restart occurred.