roachtest: fix for tpcc tests against older versions #54884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log the backup object URL and return it as part of any error. Release note: None
|
This change is |
RaduBerinde
force-pushed
the
fixture-obj-msg
branch
from
f5a3cda to
52539bd
Compare
Add the `--deprecated-fk-indexes` flag when using a fixture (and not just `init`). Note that although this is the right thing to do, we don't have these fixtures yet. Unfortunately, 20.1 and older aren't able to load backups created by 20.2 in the first place. Release note: None
RaduBerinde
force-pushed
the
fixture-obj-msg
branch
from
52539bd to
64392f1
Compare
nvanbenschoten
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
RaduBerinde
changed the title
|
Build succeeded: |
This was referenced Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workload: show the backup object name
Log the backup object URL and return it as part of any error.
Release note: None
roachtest: fix for tpcc tests against older versions
Add the
--deprecated-fk-indexesflag when using a fixture (and notjust
init).Note that although this is the right thing to do, we don't have these
fixtures yet. Unfortunately, 20.1 and older aren't able to load
backups created by 20.2 in the first place.
Release note: None