tree: correct sizes for geospatial datums #54868
Merged
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
sumeerbhola
requested changes
Sep 28, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/sem/tree/datum.go, line 2833 at r1 (raw file):
bboxSize = unsafe.Sizeof(*bbox) } return unsafe.Sizeof(*d) + bboxSize + uintptr(len(d.EWKB()))
how about a SpatialObjectSize function and use it in both places?
These were previously inaccurate, which may result in OOMs. Release note: None
otan
commented
Sep 28, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sem/tree/datum.go, line 2833 at r1 (raw file):
Previously, sumeerbhola wrote…
how about a
SpatialObjectSizefunction and use it in both places?
Done.
sumeerbhola
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
|
bors r=sumeerbhola |
1 similar comment
|
bors r=sumeerbhola |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously inaccurate, which may result in OOMs.
Release note: None