workload: bump the tpcc fixture version; create statistics when making fixtures #54772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TPCC fixtures need refreshing: they contain FK indexes that we no longer need, and they are missing stats for some of the tables. This commit bumps the fixture version and incorporates the `deprecated-fk-indexes` flag into the fixture name. Release note: None
|
This change is |
nvanbenschoten
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
pkg/ccl/workloadccl/fixture.go, line 65 at r2 (raw file):
// If TableStats is true, CREATE STATISTICS is called on all tables before // crating the fixture.
"creating"
|
TFTR! Heh, maybe a crate is the right way to store a fixture! |
`workload make` imports a workload and then creates the backup (that can be later used by `workload load`). This change adds functionality to call CREATE STATISTICS on all tables before creating the backup. This can be turned off using a flag. Release note: None
RaduBerinde
force-pushed
the
tpcc-fixtures
branch
from
7f8c776 to
7ef8ac1
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workload: bump the tpcc fixture version
The TPCC fixtures need refreshing: they contain FK indexes that we no
longer need, and they are missing stats for some of the tables.
This commit bumps the fixture version and incorporates the
deprecated-fk-indexesflag into the fixture name.Release note: None
workload: create statistics when making fixtures
workload makeimports a workload and then creates the backup (thatcan be later used by
workload load).This change adds functionality to call CREATE STATISTICS on all tables
before creating the backup. This can be turned off using a flag.
Release note: None
I am in the process of regenerating the fixtures with the new version.
Informs #54702.
Informs #50911.