sql: update search_path semantics to match pg now that we support UDS #54538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Postgres semantics dictate that the default search_path should be `$user, public`, where `$user` expands to the current user's username. This wasn't a problem until now as we lacked support for user defined schemas, which meant a schema by the name of `$user` wouldn't ever exist. This however had changed now and this patch brings us in line with the PG semantics. Fixes cockroachdb#53560 Release note (sql change): The default search path for all sessions is now `$user, public` (as opposed to just `public`). This affects our name resolution semantics -- now, if a table is present in both the public schema and the schema named the current user's username, an unqualified object name will be searched/placed in the user's schema. This doesn't impact the search semantics of tables in pg_catalog/information_schema/temp_schema -- these continued to be searched before checking the $user schema and the public schema.
arulajmani
force-pushed
the
search-path-user
branch
from
cf882fd to
bd03b17
Compare
otan
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2.
Reviewable status:
pkg/sql/sessiondata/search_path.go, line 26 at r2 (raw file):
const PublicSchemaName = "public" // UserSchemaName is the alias for schema names for users.
got him
|
GoLint catching my typos. 😅 TFTR bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres semantics dictate that the default search_path should be
$user, public, where$userexpands to the current user's username.This wasn't a problem until now as we lacked support for user defined
schemas, which meant a schema by the name of
$userwouldn't everexist. This however had changed now and this patch brings us in line
with the PG semantics.
Fixes #53560
Release note (sql change): The default search path for all sessions is
now
$user, public(as opposed to justpublic). This affects ourname resolution semantics -- now, if a table is present in both the
public schema and the schema named the current user's username, an
unqualified object name will be searched/placed in the user's schema.
This doesn't impact the search semantics of tables in
pg_catalog/information_schema/temp_schema -- these continued to be
searched before checking the $user schema and the public schema.