release-20.2: rowexec: fix column mapping for index join #54454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Index join code has been recently merged into the join reader processor. However, the setup of the joiner base has been done slightly incorrectly: the join reader core returns the whole rows from the table (i.e. all columns from the "right") and ignores columns coming from the input (from the "left"), but previously we were incorrectly passing in non-empty types for the left side - this would result in an incorrectly setup ProcOutputHelper. This could result in a crash when a row doesn't pass the filter and the verbose logging is enabled. This had a limited impact though because the output rows matched with the indexed vars referring to the columns of that row. Release note: None
|
This change is |
40 tasks
asubiotto
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
|
Oh yeah, indeed, TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #54386.
/cc @cockroachdb/release
Index join code has been recently merged into the join reader processor.
However, the setup of the joiner base has been done slightly
incorrectly: the join reader core returns the whole row from the table
(i.e. all columns from the "right") and ignores columns coming from the
input (from the "left"), but previously we were incorrectly passing in
non-empty types for the left side - this would result in an incorrectly
setup ProcOutputHelper. This could result in a crash when a row doesn't
pass the filter and the verbose logging is enabled. This had a limited
impact though because the output rows matched with the indexed vars
referring to the columns of that row.
Fixes: #54226.
Release note: None