-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geos: fix compile error with -Wsign-conversion #53702
Conversation
Not sure why this wasn't caught in cockroachdb#53647. Release justification: bug fixes and low-risk updates to new functionality Release note: None
cc @petermattis do you know why this wasn't caught in CI, but was in https://teamcity.cockroachdb.com/viewLog.html?buildId=2235367&tab=buildResultsDiv&buildTypeId=Cockroach_UnitTests_Testrace? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained
bors r=sumeerbhola |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @petermattis do you know why this wasn't caught in CI, but was in https://teamcity.cockroachdb.com/viewLog.html?buildId=2235367&tab=buildResultsDiv&buildTypeId=Cockroach_UnitTests_Testrace?
I don't know. Maybe some artifact reuse thingy.
Reviewable status: complete! 1 of 0 LGTMs obtained
ick. |
This PR was included in a batch that was canceled, it will be automatically retried |
Build succeeded: |
Not sure why this wasn't caught in #53647.
Release justification: bug fixes and low-risk updates to new
functionality
Release note: None