-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geo/geomfn: implement ST_SymmetricDifference #53688
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing: 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
SELECT | ||
a.dsc, | ||
b.dsc, | ||
ST_AsEWKT(ST_Intersection(a.geom, b.geom)), | ||
ST_Intersection(a.geom, b.geom) = ST_Intersection(a.geom::string, b.geom::string), | ||
ST_AsEWKT(ST_SymDifference(a.geom, b.geom)) | ||
ST_AsEWKT(ST_SymDifference(a.geom, b.geom)), | ||
ST_AsEWKT(ST_SymmetricDifference(a.geom, b.geom)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! quick comment -- can you move both these symdifference statements to a separate select?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
Added ST_SymmetricDifference builtin. ST_SymmetricDifference is simply an alias for ST_SymDifference. Release justification: low-risk update to new functionality Release note (sql change): Implemented the geometry based builtin . Resolves: cockroachdb#49052
f5da2d4
to
efd0bea
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
bors r+ thanks! |
This PR was included in a batch that was canceled, it will be automatically retried |
Build succeeded: |
Added ST_SymmetricDifference builtin.
ST_SymmetricDifference is simply an alias for ST_SymDifference.
Release justification: low-risk update to new functionality
Release note (sql change): Implemented the geometry based builtin
ST_SymmetricDifference
.Resolves: #49052