kvserver/tenantrate: fix flakey test #53661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was broken in cockroachdb#53510 which augmented the limiter machinery to deal with read and write requests independently. The problem is that the timer machinery works to synchronize the first blocked request but not subsequent requests. That leaves the test-writer with no fundamental means to ensure that subsequent blocked commands synchronize with a metrics command. This lack of synchronization on metrics was a pain-point when writing the original tests and led to excessive use of timers as synchronization. Rather than trying to add excess synchronization, this commit just adds a succeeds soon around the metrics. This works well. Fixes cockroachdb#53590 Release justification: non-production code changes Release note: None
|
This change is |
nvanbenschoten
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r=nvanbenschoten |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was broken in #53510 which augmented the limiter machinery to
deal with read and write requests independently. The problem is that the
timer machinery works to synchronize the first blocked request but not
subsequent requests. That leaves the test-writer with no fundamental
means to ensure that subsequent blocked commands synchronize with a
metrics command. This lack of synchronization on metrics was a pain-point
when writing the original tests and led to excessive use of timers as
synchronization. Rather than trying to add excess synchronization, this
commit just adds a succeeds soon around the metrics. This works well.
Fixes #53590
Release justification: non-production code changes
Release note: None