Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement ST_ForceCollection #53643

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

erikgrinaker
Copy link
Contributor

Some test cases deviate from PostGIS due to a bug in the WKT encoder (see #53632). The behavior of ST_ForceCollection is correct, but the WKT output does not accurately represent the resulting geometry. Not sure if we should wait for the upstream fix or merge this as-is.

Release justification: low risk, high benefit changes to existing functionality

Release note (sql change): Implement the geometry builtin
ST_ForceCollection.

Closes #48934.

@blathers-crl
Copy link

blathers-crl bot commented Aug 30, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Aug 30, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot requested a review from otan August 30, 2020 14:01
@otan
Copy link
Contributor

otan commented Aug 30, 2020

Let's wait for the upstream changes (I'll patch GEOS with the relevant fix), should be able to do this Monday!

@blathers-crl
Copy link

blathers-crl bot commented Aug 31, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@erikgrinaker
Copy link
Contributor Author

Thanks for the dep bumps and fixes! Rebased onto master and updated tests.

@otan
Copy link
Contributor

otan commented Aug 31, 2020

bors r+

Release justification: low risk, high benefit changes to existing functionality

Release note (sql change): Implement the geometry builtin
`ST_ForceCollection`.
@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Canceled.

@erikgrinaker
Copy link
Contributor Author

Rebased to fix merge conflicts.

@otan
Copy link
Contributor

otan commented Aug 31, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Build succeeded:

@craig craig bot merged commit cff29e7 into cockroachdb:master Aug 31, 2020
@erikgrinaker erikgrinaker deleted the st_forcecollection branch March 19, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_ForceCollection({geometry})
3 participants