-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builtins: implement ST_ForceCollection #53643
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Let's wait for the upstream changes (I'll patch GEOS with the relevant fix), should be able to do this Monday! |
ef740e1
to
3405594
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Thanks for the dep bumps and fixes! Rebased onto |
bors r+ |
Release justification: low risk, high benefit changes to existing functionality Release note (sql change): Implement the geometry builtin `ST_ForceCollection`.
3405594
to
dea9bf4
Compare
Canceled. |
Rebased to fix merge conflicts. |
bors r+ |
Build succeeded: |
Some test cases deviate from PostGIS due to a bug in the WKT encoder (see #53632). The behavior of
ST_ForceCollection
is correct, but the WKT output does not accurately represent the resulting geometry. Not sure if we should wait for the upstream fix or merge this as-is.Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): Implement the geometry builtin
ST_ForceCollection
.Closes #48934.