geo/geomfn: implement ST_SymDifference #53636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing: 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
blathers-crl
bot
added
O-community
|
This change is |
Added ST_SymDifference builtin. Release justification: low-risk update to new functionality Release note (sql change): Implemented the geometry based builtin `ST_SymDifference`. Resolves: cockroachdb#49051
CyrusJavan
force-pushed
the
st_symdifference
branch
from
0ac6c48 to
6d9501e
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
otan
approved these changes
Aug 30, 2020
| @@ -66,7 +66,7 @@ func Intersection(a geo.Geometry, b geo.Geometry) (geo.Geometry, error) { | |||
| return geo.ParseGeometryFromEWKB(retEWKB) | |||
| } | |||
|
|
|||
| // Union returns the geometries of intersection between A and B. | |||
| // Union returns the geometries of union between A and B. | |||
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ST_SymDifference builtin.
Release note (sql change): Implemented the geometry based builtin
ST_SymDifference.Release justification: low-risk update to new functionality
Resolves: #49051