Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix TESTS env variable in roachtest nightly script #53600

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

adityamaru
Copy link
Contributor

AWS TC nightly fails with unbound variable TESTS. This
change initializes it outside the if condition.

Release justification: non-production code changes

AWS TC nightly fails with `unbound variable TESTS`. This
change initializes it outside the if condition.

Release justification: non-production code changes
@adityamaru adityamaru requested a review from jlinder August 28, 2020 12:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

@adityamaru
Copy link
Contributor Author

Running a full AWS nightly, just to be doubly sure! - https://teamcity.cockroachdb.com/viewQueued.html?itemId=2230581

@adityamaru
Copy link
Contributor Author

It all passed - https://teamcity.cockroachdb.com/viewLog.html?buildId=2230581&buildTypeId=Cockroach_Nightlies_RoachtestNightlyAws.

Going to switch both GCE and AWS to the template once this is merged.

@adityamaru
Copy link
Contributor Author

TFTR!

bors r=jlinder

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Build succeeded:

@craig craig bot merged commit cff29e7 into cockroachdb:master Aug 31, 2020
@adityamaru adityamaru deleted the roachtest-script-mod branch August 31, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants