Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: skip and reown tests #53544

Merged
merged 4 commits into from
Aug 27, 2020
+10 −5
Merged

roachtest: skip and reown tests #53544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd576c0
roachtest: own disk-stalled roachtest to storage team
tbg Aug 27, 2020
286e3c0
roachtest: require 20.1+ for some tpccbench versions
tbg Aug 27, 2020
38af676
roachtest: run jepsen on 20.1+ only
tbg Aug 27, 2020
5343d56
roachtest: de-flake gossip/peerings
tbg Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/disk_stall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func registerDiskStalledDetection(r *testRegistry) {
"disk-stalled/log=%t,data=%t",
affectsLogDir, affectsDataDir,
),
Owner: OwnerKV,
Owner: OwnerStorage,
MinVersion: "v19.2.0",
Cluster: makeClusterSpec(1),
Run: func(ctx context.Context, t *test, c *cluster) {
Expand Down
3 changes: 3 additions & 0 deletions pkg/cmd/roachtest/gossip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@ func runGossipPeerings(ctx context.Context, t *test, c *cluster) {
t.l.Printf("%d: restarting node %d\n", i, node[0])
c.Stop(ctx, node)
c.Start(ctx, t, node)
// Sleep a bit to avoid hitting:
// https://github.com/cockroachdb/cockroach/issues/48005
time.Sleep(3 * time.Second)
}
}

Expand Down
6 changes: 4 additions & 2 deletions pkg/cmd/roachtest/jepsen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,10 @@ func registerJepsen(r *testRegistry) {
for _, nemesis := range jepsenNemeses {
nemesis := nemesis // copy for closure
spec := testSpec{
Name: fmt.Sprintf("jepsen/%s/%s", testName, nemesis.name),
Owner: OwnerKV,
Name: fmt.Sprintf("jepsen/%s/%s", testName, nemesis.name),
// We don't run jepsen on older releases due to the high rate of flakes.
MinVersion: "v20.1.0",
Owner: OwnerKV,
// The Jepsen tests do funky things to machines, like muck with the
// system clock; therefore, their clusters cannot be reused other tests
// except the Jepsen ones themselves which reset all this state when
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/tpcc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ func registerTPCC(r *testRegistry) {
LoadWarehouses: 5000,
EstimatedMax: 3000,

MinVersion: "v19.1.0",
MinVersion: "v20.1.0",
})
registerTPCCBenchSpec(r, tpccBenchSpec{
Nodes: 9,
Expand All @@ -425,7 +425,7 @@ func registerTPCC(r *testRegistry) {
LoadWarehouses: 2000,
EstimatedMax: 900,

MinVersion: "v19.1.0",
MinVersion: "v20.1.0",
})
}

Expand Down