backupccl: prevent temporary tables from backupccl #53478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
backupccl_temp_table
branch
2 times, most recently
from
4d824db to
eba07f7
Compare
pbardea
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Thanks! One small testing comment
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @otan and @pbardea)
pkg/ccl/backupccl/testdata/backup-restore/temp-tables, line 39 at r1 (raw file):
exec-sql BACKUP DATABASE d1 TO 'nodelocal://0/d1_backup/'
For completeness, can we also add a test for BACKUP DATABASE d1.*?
otan
commented
Aug 27, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/backupccl/testdata/backup-restore/temp-tables, line 39 at r1 (raw file):
Previously, pbardea (Paul Bardea) wrote…
For completeness, can we also add a test for
BACKUP DATABASE d1.*?
Done.
Filter out temporary tables from resolvable descriptors. Release justification: low risk, high benefit changes Release note (sql change): Fix a bug where temporary tables may be included in `BACKUP` commands.
otan
force-pushed
the
backupccl_temp_table
branch
from
eba07f7 to
d3b7085
Compare
pbardea
approved these changes
Aug 27, 2020
|
bors r=pbardea |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out temporary tables from resolvable descriptors.
Release justification: low risk, high benefit changes
Resolves: #50902
Release note (sql change): Fix a bug where temporary tables may be
included in
BACKUPcommands.