release-19.2: sql: allow DEALLOCATE ALL with a prepared statement #52992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
celiala
approved these changes
Aug 18, 2020
| {"Type":"CommandComplete","CommandTag":"DISCARD"} | ||
| {"Type":"ReadyForQuery","TxStatus":"I"} | ||
|
|
||
| # Send a simple query in the middle of extended protocol, which is apparently |
There was a problem hiding this comment.
This already existed in master, but is added in this PR -- I'm guessing that's intended/okay?
rafiss
force-pushed
the
backport19.2-52940
branch
from
071c153 to
fecee65
Compare
rafiss
force-pushed
the
backport19.2-52940
branch
from
fecee65 to
744fde5
Compare
asubiotto
reviewed
Aug 19, 2020
There was a problem hiding this comment.
I would keep the other pgjdbc test case out of the file since it's unrelated. We probably also need to do a small test rewrite:
--- FAIL: TestPGTest/pgjdbc (0.02s)
datadriven.go:53:
testdata/pgtest/pgjdbc:43: ReadyForQuery
expected:
{"Type":"ParameterStatus","Name":"application_name","Value":""}
{"Type":"ParameterStatus","Name":"TimeZone","Value":"UTC"}
{"Type":"CommandComplete","CommandTag":"DISCARD"}
{"Type":"ReadyForQuery","TxStatus":"I"}
found:
{"Type":"CommandComplete","CommandTag":"DISCARD"}
{"Type":"ReadyForQuery","TxStatus":"I"}
I think this is expected (#42376)
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @asubiotto, @rafiss, and @yuzefovich)
rafiss
commented
Aug 19, 2020
There was a problem hiding this comment.
thanks for catching those! fixed
Reviewable status:
PR cockroachdb#48842 added logic to exhaust portals after executing them. This had issues when the portal being executed closes itself, which happens when using DEALLOCATE in a prepared statement. Now we check if the portal still exists before exhausting it. There is no release note as this fixes a bug that only exists in unreleased versions. Release note: None
rafiss
force-pushed
the
backport19.2-52940
branch
from
744fde5 to
076572c
Compare
asubiotto
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #52940.
/cc @cockroachdb/release
PR #48842 added logic to exhaust portals after executing them. This had
issues when the portal being executed closes itself, which happens when
using DEALLOCATE in a prepared statement. Now we check if the portal
still exists before exhausting it.
There is no release note as this fixes a bug that only exists in
unreleased versions.
fixes #52915
fixes #52220
fixes #52880
fixes #52506
Release note: None