tpcc: remove uneeded origin FK indexes #52931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@nvanbenschoten do you know how to update our fixtures for this? |
nvanbenschoten
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Nice!
do you know how to update our fixtures for this?
I think this is what workload fixtures make is for. It IMPORTs a dataset into a cluster and then stores a BACKUP in our "fixtures" GCS bucket.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
Thanks! I'll do that once this PR lands. I assume that this command will take hours to complete... |
Work for cockroachdb#50911. This commit removes the `history_customer_fk_idx`, `history_district_fk_idx` and `order_line_stock_fk_idx` indexes from the TPCC schema, as they are no longer needed. Release note: None
|
bors r+ |
|
Build succeeded: |
nvanbenschoten
added a commit
to nvanbenschoten/cockroach
that referenced
this pull request
Sep 8, 2020
We were quoting the table name in order to avoid clashing with the reserved keyword, but this was tripping up the index existence check. We were then silently swallowing this error. This meant that the table was not properly partitioned, which likely had a large negative impact on New-Order transactions, which insert into the table. While here, remove references to the three indexes deleted in cockroachdb#52931. Release justification: testing only.
craig bot
pushed a commit
that referenced
this pull request
Sep 10, 2020
54064: workload/tpcc: properly partition order.order_idx index r=nvanbenschoten a=nvanbenschoten Spotted by @drewdeally. We were quoting the table name in order to avoid clashing with the reserved keyword, but this was tripping up the index existence check. We were then silently swallowing this error. This meant that the table was not properly partitioned, which likely had a large negative impact on New-Order transactions, which insert into the table. While here, remove references to the three indexes deleted in #52931. Release justification: testing only. Co-authored-by: Nathan VanBenschoten <[email protected]>
nvanbenschoten
added a commit
to nvanbenschoten/cockroach
that referenced
this pull request
Oct 16, 2020
We were quoting the table name in order to avoid clashing with the reserved keyword, but this was tripping up the index existence check. We were then silently swallowing this error. This meant that the table was not properly partitioned, which likely had a large negative impact on New-Order transactions, which insert into the table. While here, remove references to the three indexes deleted in cockroachdb#52931. Release justification: testing only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #50911.
This commit removes the
history_customer_fk_idx,history_district_fk_idxandorder_line_stock_fk_idxindexes from theTPCC schema, as they are no longer needed.
Release note: None