roachtest: continue using experimental_follower_read_timestamp() builtin #52925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
complete! 0 of 0 LGTMs obtained (waiting on 
nvanbenschoten
force-pushed
the
nvanbenschoten/expFollowerRead
branch
from
53e3b0f to
cf3c973
Compare
Fixes cockroachdb#52612. Fixes cockroachdb#52614. Fixes cockroachdb#52615. Fixes cockroachdb#52876. In 7284376, we removed the "experimental_" prefix from the `experimental_follower_read_timestamp()` builtin. This accidentally broke the `follower-reads/nodes=3` roachtest on everything but `master`. To maintain backwards compatibility, continue using the old form of the builtin in roachtests.
nvanbenschoten
force-pushed
the
nvanbenschoten/expFollowerRead
branch
from
cf3c973 to
6a071ce
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52612.
Fixes #52614.
Fixes #52615.
Fixes #52876.
In 7284376, we removed the "experimental_" prefix from the
experimental_follower_read_timestamp()builtin. This accidentallybroke the
follower-reads/nodes=3roachtest on everything butmaster.To maintain backwards compatibility, continue using the old form of the
builtin in roachtests.