sql: use a structured error to detect roachpb.BatchTimestampBeforeGCE… #52015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I could see killing the test. i just wanted to make sure that it did make it across the network correctly. |
ajwerner
force-pushed
the
ajwerner/use-structured-error-in-schema-changer
branch
from
8fc961e to
14e087f
Compare
thoszhang
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
I could take or leave the test. It seems like it's mostly just testing that the library works. But having it is fine.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
…rror Fixes cockroachdb#50198. See the issue for more details. This issue is so obscure it does not deserve a release note. Release note: None
ajwerner
force-pushed
the
ajwerner/use-structured-error-in-schema-changer
branch
from
14e087f to
27f8f1e
Compare
|
bors r=lucy-zhang |
|
Build failed: |
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
thanks 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rror
Fixes #50198.
See the issue for more details. This issue is so obscure it does not deserve
a release note.
Release note: None