roachtest: skip kv/rangelookups/split #51918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is currently flaking on master. Let's skip it until @nvanbenschoten's PRs (cockroachdb#51894 and cockroachdb#51888) resulting from the fallout from the Go1.14 upgrade are in. Release note: None
|
This change is |
|
Are we sure that #51096 is failing for the same reason as #50865? I'd actually guess that it has more to do with the recent range cache changes @andreimatei's been making. Specifically, the timing of #51437 is suspect. That change might be altering the number of range lookups we expect under heavy splitting, for better or worse. |
irfansharif
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
The skip LGTM given we're tracking this failure mode in #51096. Me associating it with the other splits related issue was unprincipled, so do assign that to @andreimatei if it isn't the same thing.
|
I'll take a look at the test |
|
Fixing the test in #52202, so I think this PR can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently flaking on master. Let's skip it until
@nvanbenschoten's PRs (#51894 and #51888) resulting from the fallout
from the Go1.14 upgrade are in.
Release note: None