cloud: add statefulset config for EKS multi-region #51775
Conversation
|
This change is |
| --advertise-host $(hostname -f) | ||
| --http-addr 0.0.0.0 | ||
| # TODO: Replace the placeholder values in --join and --locality with the namespace of the CockroachDB cluster in each region (e.g., us-east-1). | ||
| # --join cockroachdb-0.cockroachdb.<cluster-namespace-1>,cockroachdb-1.cockroachdb.<cluster-namespace-1>,cockroachdb-2.cockroachdb.<cluster-namespace-1>,cockroachdb-0.cockroachdb.<cluster-namespace-2>,cockroachdb-1.cockroachdb.<cluster-namespace-2>,cockroachdb-2.cockroachdb.<cluster-namespace-2>,cockroachdb-0.cockroachdb.<cluster-namespace-3>,cockroachdb-1.cockroachdb.<cluster-namespace-3>,cockroachdb-2.cockroachdb.<cluster-namespace-3> |
There was a problem hiding this comment.
Taking into account this comment on the --join flag, am I safe to remove one node (e.g. cockroachdb-2) from each region here?
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @taroface)
a discussion (no related file):
The Kubernetes manifests look good to me, as long as there's other documentation to go along with it. It might be helpful to add a README about how to use these manifests. I realize there might be some text on the docs site, but if people find these manifests without going through the docs site, they might be confused on how to use them.
Relatedly, it might be nice to create a separate directory for the multiregion EKS manifests, to separate it from the existing manifests in this directory.
cloud/kubernetes/multiregion/cockroachdb-statefulset-secure-eks.yaml, line 253 at r4 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Taking into account this comment on the --join flag, am I safe to remove one node (e.g.
cockroachdb-2) from each region here?
You're definitely safe to, though I also think it's fine to leave it.
|
@DuskEagle TFTR! I moved the files and added a README, also slightly updating the existing README in |
There was a problem hiding this comment.
Reviewable status:
cloud/kubernetes/multiregion/eks/README.md, line 73 at r5 (raw file):
- `region2` and `region3` with the namespaces in which the CockroachDB pods will run in the other 2 regions. - `ip1`, `ip2`, and `ip3` with the IP addresses of the EKS instances in the region.
This should be the IP addresses of the Network Load Balancerss in the other regions, not the EKS VMs.
taroface
force-pushed
the
taroface-patch-2
branch
from
d1647f1 to
4474d83
Compare
|
bors r+ |
|
Build succeeded: |
This StatefulSet config is meant for use with the EKS multi-region docs (WIP).
initContainerthat determines the AZ of each pod.namespacefield to fill in with a region-appropriate namespace.--joinand--localityin the start command for the user to customize with namespace/region names. I am unclear on whether the values here need to match thenamespacedefined for the cluster above.dns-lb-eks.yamlfor creating an EKS network load balancer.configmap.yamlfor modifying the Corefile.