rowexec: fix bug where windower was not using fingerprint #49234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
approved these changes
May 19, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @rohany)
pkg/sql/logictest/testdata/logic_test/window, line 3810 at r1 (raw file):
1 2 2 2 1 1 # Regression test for windower not using EncDatum.Fingerprint.
nit: Would you mind putting this in the orms logic test please?
Release note (bug fix): Fix a bug with use of arrays combined with window functions causing a query failure.
yuzefovich
approved these changes
May 19, 2020
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status:
|
TFTRs! Moved it over to bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (bug fix): Fix a bug with use of arrays combined with
window functions causing a query failure.