schemachange: more informative dependent job descriptions #48163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
❌ The GitHub CI (Cockroach) build has failed on 08c9bed2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
thoszhang
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Should we backport to 20.1?
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
spaskob
commented
Apr 30, 2020
There was a problem hiding this comment.
yes, that make sense
Reviewable status:
`DROP xxx` statements have cascading effects of causing sequences, indexes and views being dropped as well. We should name the jobs that execute them accordingly so that it is clear to users that they are connected to the inital `DROP` statement. Fixes cockroachdb#35051. Release note (bug fix): Better distinguish between the delete jobs for columns and dependent jobs for deleting indices, views and sequences. In the current state clients were confused why more than 1 job was created from a `DROP COLUMN` statement.
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DROP xxxstatements have cascading effects of causing sequences, indexesand views being dropped as well. We should name the jobs that execute them
accordingly so that it is clear to users that they are connected to the
inital
DROPstatement.Fixes #35051.
Release note (bug fix): Better distinguish between the delete jobs for
columns and dependent jobs for deleting indices, views and sequences. In the
current state clients were confused why more than 1 job was created from
a
DROP COLUMNstatement.