kvserver,roachtest/hotspotsplits: adjust constants to ensure backpressure #47164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
❌ The GitHub CI (Cockroach) build has failed on 0dc527a2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. I am experimental - my owner is otan. |
nvanbenschoten
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
We can also do the math to convince ourselves that this is sufficient, given that there's a fixed concurrency of 32.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
This commit increases backpressureByteTolerance in order to make it less fragile in the face of large concurrent writes. This smaller setting was chosen prior to implementing the additional mitigations in cockroachdb#46271. Release note: None
This commit changes the size of writes for the test from 512 to 256 kb. The reason for this change is to make it such that the inflight writes of the test don't push a range over the backpressureByteTolerance before backpressure begins. Prior to this PR and the one preceding it, this test failed 10/10 times. Afterwards it did not fail. Release note: None
ajwerner
force-pushed
the
ajwerner/fix-hotspot-splits
branch
from
0dc527a to
7e82c23
Compare
|
❌ The GitHub CI (Cockroach) build has failed on 7e82c23d. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. I am experimental - my owner is otan. |
|
flaked on #46713 (comment) bors r=nvanbenschoten |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Fixes #46957.