backupccl: remove legacy aux-dir check in tests #44539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
A long itme ago backup/restore used on-disk tempfiles and added this testing check to ensure they were cleaned up but that has long since changed to in-memory and this check is no longer relevant to backup/restore. Release note: none
dt
force-pushed
the
backup-remove-aux-check
branch
from
5d1976c to
5db2559
Compare
miretskiy
approved these changes
Feb 4, 2020
|
bors r+ |
Build failed (retrying...) |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 4, 2020
44539: backupccl: remove legacy aux-dir check in tests r=dt a=dt A long itme ago backup/restore used on-disk tempfiles and added this testing check to ensure they were cleaned up but that has long since changed to in-memory and this check is no longer relevant to backup/restore. Release note: none Co-authored-by: David Taylor <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long itme ago backup/restore used on-disk tempfiles and added this testing check
to ensure they were cleaned up but that has long since changed to in-memory and
this check is no longer relevant to backup/restore.
Release note: none