Merge pull request #44065 from knz/backport19.2-44064 #44065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (bug fix): `cockroach zip` now emits the `goroutine` file in the proper sub-directory when the corresponding call fails with an error.
Release note: None
Release note: None
|
This change is |
The recent addition of the goroutine dump collection in cockroachdb#36813 introduced a bug where `debug zip` would prematurely stop if it could not request the goroutine file list. This patch fixes that. Release note (bug fix): `cockroach debug zip` is again able to operate correctly and continue to iterate over all nodes if one of the nodes does not deliver its goroutine dumps. It would previously prematurely and incorrectly stop with an incomplete dump; this was a regression introduced in 19.2.
knz
force-pushed
the
backport19.2-44064
branch
from
700dc07 to
f59aae1
Compare
|
LGTM
…On Thu, Jan 16, 2020 at 2:06 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/44065>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#44065?email_source=notifications&email_token=ABGXPZHFTX5YKQ7IDZWUAMLQ6BLTTA5CNFSM4KHTWV7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJD7TVA#issuecomment-575142356>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGXPZHUCILGWGHWBFTQJ7DQ6BLTTANCNFSM4KHTWV7A>
.
|
tbg
approved these changes
Jan 16, 2020
knz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4/4 commits from #44064.
/cc @cockroachdb/release
Fixes #43966.
Mostly fixes the
zipregression introduced in 19.2 by #36813.