pgwire: convert a few more auth tests to datadriven input #43725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
2020014-simplify-test
branch
from
128495b to
35c43b9
Compare
maddyblue
approved these changes
Jan 6, 2020
|
|
||
| # Verify auth fails without password. | ||
| # | ||
| # Also verify that the username gets normalized: the username |
There was a problem hiding this comment.
Do we also need to test here that the non-normalized username (i.e., the one provide initially) also works?
knz
force-pushed
the
2020014-simplify-test
branch
from
35c43b9 to
aeca380
Compare
TestPGWire, RootUserAuth and TestUserAuth had been converted already. This completes by converting UnicodeUserAuth and also using that to exercise username normalization. The patch also converts TestPGWireNonexistentUser in insecure mode (a test already existed for secure mode). It also makes `connect` tests print out the name of the current db after login, and uses that to replace TestPGWireDBName. Release note: None
|
TFYR! bors r+ |
knz
force-pushed
the
2020014-simplify-test
branch
from
aeca380 to
14def93
Compare
craig bot
pushed a commit
that referenced
this pull request
Jan 6, 2020
43725: pgwire: convert a few more auth tests to datadriven input r=knz a=knz TestPGWire, RootUserAuth and TestUserAuth had been converted already. This completes by converting UnicodeUserAuth and also using that to exercise username normalization. The patch also converts TestPGWireNonexistentUser in insecure mode (a test already existed for secure mode). It also makes `connect` tests print out the name of the current db after login, and uses that to replace TestPGWireDBName. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
|
(simplifies fixing #31113) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestPGWire, RootUserAuth and TestUserAuth had been converted already.
This completes by converting UnicodeUserAuth and also using that to
exercise username normalization.
The patch also converts TestPGWireNonexistentUser in insecure mode (a
test already existed for secure mode).
It also makes
connecttests print out the name of the current dbafter login, and uses that to replace TestPGWireDBName.
Release note: None