blobs,changefeedccl: append ".tmp" to temp files + deflake TestChangefeedNemeses #42987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
danhhz
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @danhhz and @knz)
pkg/ccl/changefeedccl/cdctest/testfeed.go, line 626 at r1 (raw file):
return nil } if strings.HasSuffix(path, ".tmp") {
looks like we already have this check on line 617. ha!
🤦♂️ |
…feedNemeses Prior to this test the blob storage would merely append random numbers at the end of the file name to generate temp file names. This was confusing TestChangefeedNemeses which checks the validity of the various files in the target directory. This patch fixes it by using a `.tmp` suffix for temp files. These are already properly ignored by the walk performed by TestChangefeedNemeses. Release note: None
|
TFYR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 5, 2019
42970: opt: split tpch stats quality tests r=RaduBerinde a=RaduBerinde opt: split tpch stats quality tests Splitting the tpch stats quality tests into more manageable multiple files, one per query. This allows re-running only particular queries. Release note: None ---- opt: convert panics to errors for stats directive Currently if a plan changes and a save table name is no longer correct, we get a panic. The panic is annoying to work with (it stops running other subtests). This change converts the panic in this case to an error. Release note: None 42987: blobs,changefeedccl: append ".tmp" to temp files + deflake TestChangefeedNemeses r=knz a=knz Fixes #42978. Prior to this test the blob storage would merely append random numbers at the end of the file name to generate temp file names. This was confusing TestChangefeedNemeses which checks the validity of the various files in the target directory. This patch fixes it by: - using a `.tmp` suffix for temp files - excluding `.tmp` files from the walk performed by TestChangefeedNemeses Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42978.
Prior to this test the blob storage would merely append random numbers
at the end of the file name to generate temp file names. This was
confusing TestChangefeedNemeses which checks the validity of the
various files in the target directory.
This patch fixes it by:
.tmpsuffix for temp files.tmpfiles from the walk performed by TestChangefeedNemesesRelease note: None