release-2.1: storage: clear *cmd references in cmdQ buffers before re-use #42961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit places a limit on the size of the overlaps buffer than the CommandQueue uses to avoid repeat allocations in getOverlaps. It's risky to allow this buffer to grow without bounds and never be reclaimed. Release note (bug fix): The CommandQueue no longer holds on to buffers if they grow to large. This prevents unbounded growth of memory that may never be reclaimed.
|
This change is |
ajwerner
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/storage/command_queue.go, line 440 at r2 (raw file):
if restart { // Clear all *cmd references in overlaps, per the getOverlaps contract. for i := range overlaps {
nit: the shadowing of i here is a tad confusing.
This commit ensures that the *cmd references in the overlaps buffer that the CommandQueue uses to avoid repeat allocations are cleared after use. This prevents the buffer from accidentally holding references to *cmd objects and preventing them from being GCed. Release note (bug fix): The CommandQueue makes sure to clear references to objects in its buffers to allow those objects to be reclaimed by the garbage collector.
nvanbenschoten
force-pushed
the
nvanbenschoten/cmdQLeak
branch
from
c94f572 to
315781d
Compare
nvanbenschoten
commented
Dec 4, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/storage/command_queue.go, line 440 at r2 (raw file):
Previously, ajwerner wrote…
nit: the shadowing of
ihere is a tad confusing.
Agreed. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits that attempt to avoid indefinitely retaining references to large graphs of
*cmdobjects in theCommandQueueand preventing them from being GCed.storage: don't let cmdQ buffers grow without bound
This commit places a limit on the size of the overlaps buffer than the CommandQueue uses to avoid repeat allocations in getOverlaps. It's risky to allow this buffer to grow without bounds and never be reclaimed.
storage: clear *cmd references in cmdQ buffers before re-use
This commit ensures that the *cmd references in the overlaps buffer that the CommandQueue uses to avoid repeat allocations are cleared after use. This prevents the buffer from accidentally holding references to *cmd objects and preventing them from being GCed.