engine: don't create aux dir for read-only engine #41983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was mildly irritating that
./cockroach debug raft-log not/there 1
would create `not/there/auxiliary`.
Release note: None
|
This change is |
petermattis
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
I notice that we're not creating the auxiliary directory for storage/engine.Pebble. Happy to see that fixed, but also fine if you want to leave that for #storage.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @petermattis)
|
bors r=petermattis If it's OK with you I'll leave the cleanups to #storage. |
craig bot
pushed a commit
that referenced
this pull request
Oct 29, 2019
41983: engine: don't create aux dir for read-only engine r=petermattis a=tbg
It was mildly irritating that
./cockroach debug raft-log not/there 1
would create `not/there/auxiliary`.
Release note: None
41986: storage: fix stats inconsistency due to WriteTooOld optimization r=irfansharif a=tbg
This fixes a bug introduced in #22315 with the introduction of a "local
retry" to avoid WriteTooOldError inside of 1PC transactions that were
not carrying out any reads. Such a transaction can simply be
re-evaluated at a higher timestamp, which can allow it to commit.
The bug was that when such a re-evaluation was carried out, we were
not discarding the MVCCStats accrued from the first attempt. In
effect, the request would thus be double-counted in stats, which
would set off the consistency checker.
The fix is easy: discard the delta before re-evaluating.
Fixes #31870.
Release note (bug fix): remove a source of (benign) stats
inconsistencies (i.e. the stats of a range not accurately reflecting its
contents).
Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was mildly irritating that
would create
not/there/auxiliary.Release note: None