sql: fix flake in TestExecBuild/local/autocommit #41512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Please run the testfile under make stress for a bit before merging.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Broken by cockroachdb#41358. The async traces were... async, so the ordering of the trace output was non-deterministic. This commit fixes the flakiness by filtering out async trace events. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/autocommitFix
branch
from
b3c286a to
0fe8463
Compare
That caught some flakiness around intent resolution. Things look stable now. |
RaduBerinde
reviewed
Oct 10, 2019
There was a problem hiding this comment.
LGTM
Technically I think these all should have the rowsort option as there is no ORDER BY. They'll never run distributed though so in practice it shouldn't matter.
Reviewable status:
|
bors r+ |
Build failed (retrying...) |
Merge conflict (retrying...) |
1 similar comment
Merge conflict (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Oct 11, 2019
41512: sql: fix flake in TestExecBuild/local/autocommit r=nvanbenschoten a=nvanbenschoten Broken by #41358. The async traces were... async, so the ordering of the trace output was non-deterministic. This commit fixes the flakiness by filtering out async trace events. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by #41358.
The async traces were... async, so the ordering of the trace output
was non-deterministic. This commit fixes the flakiness by filtering
out async trace events.
Release note: None