release-19.2: server: add metric for number of disk stalls detected #41475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a counter metric on the Node object for the number of disk stalls detected. It might have been cleaner to attach this metric to the store associated with the engine and perhaps even to have moved this check into storage but this seemed like the least invasive place to put it. Fixes cockroachdb#38040. Release justification: Low risk, high priority monitoring change for high-serverity bugs in existing functionality. Release note: None
|
This change is |
|
Any objections to putting this in the 19.2 release? |
bdarnell
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #41337.
/cc @cockroachdb/release
This commit adds a counter metric on the Node object for the number of
disk stalls detected. It might have been cleaner to attach this metric to the
store associated with the engine and perhaps even to have moved this check into
storage but this seemed like the least invasive place to put it.
Fixes #38040.
Release justification: Low risk, high priority monitoring change for
high-severity bugs in existing functionality.
Release note: None