ui: JavaScript updates to address vulnerabilities #41291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 3, 2019 11:27
- Updating the lodash resolution - Upgrading `karma-webpack` because previous version depended on an old version of lodash that couldn't be satisfied by `4.17.15` release justification: fixing JavaScript vulnerabilities Release note (admin ui change): upgrade lodash resolution, upgrade karma-webpack
- resolving Snyk vulnerability warnings with ua-parser-js Release justification: fixing JavaScript vulnerability Release note (admin ui change): adding ua-parser-js resolution
Updating `url-loader` to resolve moderate vulnerability flagged in the npm repo. See more information at https://www.npmjs.com/advisories/535 Release justification: resolve JavaScript vulnerabilities Release note (admin ui change): upgrade url-loader (used by webpack)
I forgot about this part Release justification: Committing vendor dependencies for vulnerability update Release note: None
nathanstilwell
added
the
first-pr
|
This change is |
|
|
53 tasks
vilterp
approved these changes
Oct 3, 2019
|
@bdarnell @andy-kimball should we just |
bdarnell
approved these changes
Oct 3, 2019
|
bors r+ |
Build failed (retrying...) |
Build failed |
|
bors retry |
Canceled (will resume) |
|
bors retry |
craig bot
pushed a commit
that referenced
this pull request
Oct 4, 2019
41291: ui: JavaScript updates to address vulnerabilities r=nathanstilwell a=nathanstilwell Resolving vulnerabilities identified by Synk and npm. Specifically these, - https://app.snyk.io/vuln/SNYK-JS-LODASH-450202 - https://app.snyk.io/vuln/npm:ua-parser-js:20171012 - https://app.snyk.io/vuln/npm:ua-parser-js:20180227 - https://www.npmjs.com/advisories/535 Release justification: Resolving JavaScript vulnerabilities. Release note: Upgrading JavaScript dependencies Co-authored-by: Nathan Stilwell <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving vulnerabilities identified by Synk and npm. Specifically these,
Release justification: Resolving JavaScript vulnerabilities.
Release note: Upgrading JavaScript dependencies