changefeedccl: do rangefeed enabled check before starting job #41272
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @aayushshah15)
pkg/storage/replica_rangefeed.go, line 131 at r1 (raw file):
args *roachpb.RangeFeedRequest, stream roachpb.Internal_RangeFeedServer, ) *roachpb.Error { if !RangefeedEnabled.Get(&r.store.cfg.Settings.SV) {
There's a sort of crazy edge case where a user upgrades rapidly and there's a rangefeed job which was created on 2.1 (19.1?). It's sort of a bummer because realistically as soon as you've been on 19.2 (or even 19.1?) for long enough for the job to fail it would be fine. That being said, I think you're right that we should return an error where you are.
|
@aayushshah15 want to try to rebase this and get it in? |
|
will do, thanks for digging this up again! |
aayushshah15
force-pushed
the
changefeed_early_abort
branch
from
f1ec382 to
a34f7a4
Compare
aayushshah15
requested review from
a team and
adityamaru
and removed request for
a team and
adityamaru
aayushshah15
force-pushed
the
changefeed_early_abort
branch
2 times, most recently
from
df97a21 to
6341740
Compare
Fixes cockroachdb#41213 If we currently start a changefeed without enabling the `kv.rangefeed.enabled` cluster setting, a job first gets started and then fails when it hits the setting check during the initial `Rangefeed` setup. This PR fixes this by performing this setting check in `changefeedPlanHook` in addition to the already existing check in `Replica.Rangefeed`. Release note: None
aayushshah15
force-pushed
the
changefeed_early_abort
branch
from
6341740 to
7dec9ad
Compare
|
This is RFAL. |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:
|
TFTR! bors r=ajwerner |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Fixes #41213
If we currently start a changefeed without enabling the
kv.rangefeed.enabledcluster setting, a job first gets started andthen fails when it hits the setting check during the initial
Rangefeedsetup.
This PR fixes this by performing this setting check in
changefeedPlanHookin addition to the already existing check inReplica.Rangefeed.Release note:
CREATE CHANGEFEEDstatements no longer result in asuperfluous changefeed job being created if rangefeeds are not enabled.