sql: replace assert with error in EXPERIMENTAL_RELOCATE #41157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves cockroachdb#39835 GetInfoProto returns an error in relocateNode.Next, in case if store doesn't exist. It should not produce a stacktrace. reverts this line to pre 8cfcbb4 commit state. Release justification: low-impact assert changed to error Release note: None
|
This change is |
|
@knz: Could you take a look? It kinda reverts one of the lines that you've changed. Namely: 8cfcbb4#diff-5a06d8672e0de596cc09f178fa0ef770L183 |
|
@jordanlewis: Could you please take a look, if change is what you meant in #39835 ? |
|
LGTM. Thanks for your change! |
|
@knz: Cool! Could you please trigger bors then? |
|
absolutely bors r+ |
|
Thanks |
craig bot
pushed a commit
that referenced
this pull request
Sep 27, 2019
41157: sql: replace assert with error in EXPERIMENTAL_RELOCATE r=knz a=Gurio Resolves #39835 GetInfoProto returns an error in relocateNode.Next, in case if store doesn't exist. It should not produce a stacktrace. reverts this line to pre 8cfcbb4 commit state. Release justification: low-impact assert changed to error Release note: None Co-authored-by: Arseni Lapunov <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39835
GetInfoProto returns an error in relocateNode.Next,
in case if store doesn't exist. It should not produce a stacktrace.
reverts this line to pre 8cfcbb4 commit state.
Release justification: low-impact assert changed to error
Release note: None