distsql: put the SQL into diagrams #41129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen cases where we get an `EXPLAIN ANALYZE` output from a client and it's not clear which variation of a big query it was from. This change adds the SQL to the diagram. A corresponding change on the diagram rendering side is in progress. Release justification: low-risk change with customer benefit. Release note: None
|
This change is |
|
|
|
Lol |
jordanlewis
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @solongordon)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 1, 2019
41129: distsql: put the SQL into diagrams r=RaduBerinde a=RaduBerinde We have seen cases where we get an `EXPLAIN ANALYZE` output from a client and it's not clear which variation of a big query it was from. This change adds the SQL to the diagram. A corresponding change on the diagram rendering side is in progress. Release justification: low-risk change with customer benefit. Release note: None Co-authored-by: Radu Berinde <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen cases where we get an
EXPLAIN ANALYZEoutput from aclient and it's not clear which variation of a big query it was from.
This change adds the SQL to the diagram. A corresponding change on the
diagram rendering side is in progress.
Release justification: low-risk change with customer benefit.
Release note: None