kv: unwrap MixedSuccessError even when retry attempts exhausted #40356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a comment describing the interceptors role in the transaction model. This is similar to the comments we have on the other interceptors. Release note: None
Fixes cockroachdb#40328. Closes cockroachdb#40332. This commit fixes a bug where MixedSuccessErrors would not be unwrapped by the txnSpanRefresher when a request had exhausted its refresh attempt limit. The theory is that the race test plus the background stats computation in `TestParallel/create_stats` was causing a lot of transaction retries, which exhausted `maxTxnRefreshAttempts`. Release note: None
|
This change is |
tbg
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 30, 2019
40356: kv: unwrap MixedSuccessError even when retry attempts exhausted r=nvanbenschoten a=nvanbenschoten Fixes #40328. Closes #40332. This commit fixes a bug where MixedSuccessErrors would not be unwrapped by the txnSpanRefresher when a request had exhausted its refresh attempt limit. The theory is that the race test plus the background stats computation in `TestParallel/create_stats` was causing a lot of transaction retries, which exhausted `maxTxnRefreshAttempts`. The PR also improves the documentation on the `txnSpanRefresher`. It adds a comment describing the interceptors role in the transaction model, which is similar to the comments we have on the other interceptors. Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40328.
Closes #40332.
This commit fixes a bug where MixedSuccessErrors would not be unwrapped by the txnSpanRefresher when a request had exhausted its refresh attempt limit.
The theory is that the race test plus the background stats computation in
TestParallel/create_statswas causing a lot of transaction retries, which exhaustedmaxTxnRefreshAttempts.The PR also improves the documentation on the
txnSpanRefresher. It adds a comment describing the interceptors role in the transaction model, which is similar to the comments we have on the other interceptors.