importccl: fix mysqqoutfile import bug #40345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing from csv if the number of fields is less than the columns in the schema the server will panic. Added a check for this case. Touches 39820. Release note: None
|
This change is |
dt
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dt)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 1, 2019
40345: importccl: fix mysqqoutfile import bug r=spaskob a=spaskob When importing from csv if the number of fields is less than the columns in the schema the server will panic. Added a check for this case. Tested: Note that the test currently skipped. I added a test case and ran tests successfully locally. Touches 39820. Release note: None Co-authored-by: Spas Bojanov <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing from csv if the number of fields is less than the columns
in the schema the server will panic. Added a check for this case.
Tested: Note that the test currently skipped. I added a test case and ran tests successfully locally.
Touches 39820.
Release note: None